Make logger nullable in Transport constructors #152
Merged
+14
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camilleislasse
requested review from
CodeWithKyrian,
Nyholm and
chr-hertel
as code owners
chr-hertel
approved these changes
Nov 20, 2025
Member
|
@camilleislasse can you please sign your commit? |
- BaseTransport: Accept ?LoggerInterface parameter and convert null to NullLogger - StdioTransport: Change logger parameter to nullable - StreamableHttpTransport: Change logger parameter to nullable - InMemoryTransport: Fix missing parent::__construct() call and add logging
camilleislasse
force-pushed
the
feature/nullable-logger-in-transports
branch
from
8991ff0 to
f7d6fee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Allow passing
nullas logger parameter to avoid verbose ternary operators when the logger is optional.How Has This Been Tested?
Breaking Changes
No
Types of changes
Checklist
Additional context
https://github.com/camilleislasse/ai/blob/ecea6d676b4ea9e35ade883bda281ef1d113879d/src/mcp-bundle/src/Controller/McpController.php